Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioEffects documentation enhancements #98455

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

betalars
Copy link
Contributor

Enhancing documentation and readability of some audio effects that were not yet documented.

I did some heavy guessing with StereoEnhance, so please double check if the things I determined it to do are actually the things it is intended to do.

@betalars betalars requested review from a team as code owners October 23, 2024 11:31
@betalars betalars changed the title Audio doc enhancements AudioEffects documentation enhancements Oct 23, 2024
@AThousandShips
Copy link
Member

Your commit seems not to be linked to your GitHub account. See why are my commits linked to the wrong user? for more info.

@betalars
Copy link
Contributor Author

@AThousandShips Also thanks for reminding me to update my email address.

@betalars
Copy link
Contributor Author

BTW: I have now installed a spell checker for my VSCode.

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the definitions. They seem alright!

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Oct 23, 2024
@AThousandShips
Copy link
Member

Please squash your commits into one, see the interactive rebase for details

@betalars betalars force-pushed the audio-doc-enhancements branch 2 times, most recently from ecd4a78 to 6397a11 Compare October 23, 2024 23:14
@betalars
Copy link
Contributor Author

I'm unsure why but some of the typo fixes did get lost in the first squash, but i did another fixup squash and now alll should be good :)

@betalars betalars force-pushed the audio-doc-enhancements branch from f3332a6 to 1be2f8c Compare October 24, 2024 13:16
@Repiteo Repiteo merged commit ff5e2d7 into godotengine:master Oct 24, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 24, 2024

Thanks, and congratulations on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants