Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not delete nodes created by MultiplayerSpawner when its authority peer disconnects #97910

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Janonas
Copy link

@Janonas Janonas commented Oct 7, 2024

Very simple option that you can set using "multiplayer.set_delete_spawned_nodes_on_peer_exit(false)", which prevents a MultiplayerSpawner from automatically deleting all that is has spawned when its multiplayer authority peer disconnects.

@Janonas Janonas requested a review from a team as a code owner October 7, 2024 08:57
@Janonas
Copy link
Author

Janonas commented Oct 7, 2024

This was mad since i ran into the same issue as: godotengine/godot-proposals#9214 , I admit i am not well versed in C++, however after complining my changes seem to work fine.

@AThousandShips AThousandShips changed the title Option to not delete nodes created by MultiplayerSpawner when its authority peer disconnects Add option to not delete nodes created by MultiplayerSpawner when its authority peer disconnects Oct 7, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Oct 7, 2024
@Janonas
Copy link
Author

Janonas commented Oct 7, 2024

one thing to note is that it works when testing in editors, however when exporting with the old export templates the fix doesnt work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants