Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move skin registration process into deferred on ready #97489

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Move skin registration process into deferred on ready #97489

merged 1 commit into from
Sep 27, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Sep 26, 2024 •
edited
Loading

Fixes #97459

Since the initial update of the skin is done in the skeleton's deferred process, it seems that the process that searches for the skeleton when the skin is first loaded into the tree should also be moved to the deferred process.

However, I am not so familiar with the Skin deformation process in MeshInstance3D, so I am not sure if this is really the correct fix. Although, I think it is safe since this just move the process timing on loading, but please review/test carefully. cc @fire @MajorMcDoom

@TokageItLab TokageItLab added bug regression topic:animation topic:3d cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 26, 2024
@TokageItLab TokageItLab added this to the 4.4 milestone Sep 26, 2024
@TokageItLab TokageItLab requested a review from a team September 26, 2024 13:29
@TokageItLab TokageItLab requested a review from a team as a code owner September 26, 2024 13:29
@TokageItLab TokageItLab force-pushed the deferred-skin-registration branch from 3c7d34a to 2eb069f Compare September 26, 2024 13:37
akien-mga
akien-mga approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, that looks good to me. Let's wait for confirmation.

@MajorMcDoom
Copy link
Contributor

Seems to work on my end with the repro project!

@akien-mga akien-mga merged commit ab1f55e into godotengine:master Sep 27, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

ahxgamma referenced this pull request in ahxgamma/redot-engine Oct 1, 2024
Revert "Merge pull request #97489 from TokageItLab/deferred-skin-regi…
ef44d84 
…stration"

This reverts commit ab1f55e, reversing
changes made to 58ec7a9.
@TokageItLab TokageItLab mentioned this pull request Oct 5, 2024
Open
@matheusmdx matheusmdx mentioned this pull request Oct 8, 2024
Closed
@TokageItLab TokageItLab mentioned this pull request Oct 9, 2024
Merged
@TokageItLab TokageItLab removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Oct 9, 2024
@matheusmdx matheusmdx mentioned this pull request Oct 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

MeshInstance3D disappears at runtime if its skeleton is not a direct parent
4 participants
@TokageItLab @MajorMcDoom @akien-mga @AThousandShips