-
-
Notifications
You must be signed in to change notification settings - Fork 22.7k
WASAPI multi-channel microphone input #96947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
047501c
WASAPI multi-channel microphone input
SleeeepyZhou 880b066
Fix bugs
SleeeepyZhou b8c4040
Improve robustness
SleeeepyZhou ce41fc3
Fix bugs
SleeeepyZhou 0d2f1e8
Fix initialization
SleeeepyZhou 7d8b73c
Merge branch 'godotengine:master' into master
SleeeepyZhou d4ca15c
Merge branch 'godotengine:master' into master
SleeeepyZhou e93c7c3
Update README.md
SleeeepyZhou 5f5f0ac
Replace icon
SleeeepyZhou 1c1c4ff
Replace icon
SleeeepyZhou 216efd4
Update README
SleeeepyZhou b98d639
Update README
SleeeepyZhou a806e92
Update inf
SleeeepyZhou 492e9b5
Cat
SleeeepyZhou a15af16
Merge branch 'godotengine:master' into Main
SleeeepyZhou 8a4665f
Merge branch 'godotengine:master' into Main
SleeeepyZhou 1a1702a
New icon
SleeeepyZhou 8b2105b
Merge branch 'godotengine:master' into Main
SleeeepyZhou 2048838
icon
SleeeepyZhou 41394dc
test
SleeeepyZhou 4bafe64
test
SleeeepyZhou c59c615
Update and test
SleeeepyZhou 591e185
Test
SleeeepyZhou 079aa4f
Merge branch 'godotengine:master' into dev
SleeeepyZhou b84e915
Test
SleeeepyZhou 488d421
Merge branch 'dev' of https://github.com/SleeeepyZhou/Maodot into dev
SleeeepyZhou bc108e7
test
SleeeepyZhou 7fb850b
Clean
SleeeepyZhou 5286be7
Icons
SleeeepyZhou 85aa601
2024.10.13
SleeeepyZhou 0517795
2024.10.13
SleeeepyZhou 5a81510
Merge pull request #1 from SleeeepyZhou/dev
SleeeepyZhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can input have the odd number of channels at all (the assumption here seems to be L,R,Center channel config)?
Also, do this odd/even channel distribution to left/right always holds (is defined somewhere in the WASAPI documented, or based on specific mic sample)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the assumption that the microphone might have a potential configuration with odd channels (e.g., Left, Right, Center), although such configurations are uncommon (in some professional audio equipment). The goal was to ensure that the microphone is at least usable within Godot, regardless of the channel count. The WASAPI documentation itself doesn't explicitly specify how multi-channel microphones should be handled, so I aimed for a more general solution to accommodate various configurations.