Move NavigationServer mesh queries to dedicated file #96355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scony
requested changes
Aug 31, 2024
smix8
force-pushed
the
nav_mesh_queries
branch
from
e746265 to
7497954
Compare
Scony
approved these changes
Aug 31, 2024
AThousandShips
approved these changes
Aug 31, 2024
smix8
force-pushed
the
nav_mesh_queries
branch
from
7497954 to
2f6ee09
Compare
Moves all the navigation mesh query related functions from NavMap and NavRegion to a dedicated file and makes them static.
smix8
force-pushed
the
nav_mesh_queries
branch
from
2f6ee09 to
a4cfc77
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the navigation mesh query related read-only functions from
NavMapandNavRegionto a dedicated file and makes them static.This is done ...
I applied most of the rename suggestions from that linked region PR already here to the existing code that switched files.
For now I left the functions stumps on the NavMap and NavRegion to forward the function calls as I don't want to do an entire workaround for thread-safety and change things twice soon™.