Remove deprecated method Window::move_to_foreground()

[Chubercik]

• Follow-up of Add deprecation notice to a duplicate method of class Window #83014, self-explanatory.
• This PR can be merged as soon as the time is deemed right.

[AThousandShips]

I don't see this being removed any time soon, so I don't think this is necessary to open at this point, I wouldn't delete this method until 5.0

[Chubercik]

I wouldn't delete this method until 5.0

That's one option, another would be to choose a standard number of minor releases until a deprecation gets removed, say 3 (which would make this PR mergeable after Godot 4.6), so that the whole process in standardized and understandable for the end user - instead of saying "this will get removed" we could say "this will get removed by version 4.x" instead.

[AThousandShips]

That's not how we've done things in the past and I would say it shouldn't be done, it isn't an issue to have it there IMO, it's only very minor overhead, and honestly I'd say keeping the rule that we don't remove them until the next major release is a good incentive to not just casually deprecate things because it doesn't add as much baggage

[Mickeon]

Once it's going to be time everything that's marked as deprecated in the codebase will be removed. Doing this for one specific method is asking to ruin someone's day.

[AThousandShips]

Would absolutely have to be discussed extensively with regards to policy, I'd suggest someone should open a proposal for this

[Chubercik]

That's not how we've done things in the past and I would say it shouldn't be done, it isn't an issue to have it there IMO, it's only very minor overhead, and honestly I'd say keeping the rule that we don't remove them until the next major release is a good incentive to not just casually deprecate things because it doesn't add as much baggage

Sure, I can see why you'd prefer it that way. PR is already up, so it might as well wait for Godot 5.0.

Once it's going to be time everything that's marked as deprecated in the codebase will be removed. Doing this for one specific method is asking to ruin someone's day.

Oh, I didn't mean for my solution to only apply to this specific case, more so to set a precedent that would eventually apply to all other deprecations.

[Chubercik]

Would absolutely have to be discussed extensively with regards to policy, I'd suggest someone should open a proposal for this

godotengine/godot-proposals#10583