Clean up Viewport's forced_mouse_focus
#95902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EditorObjectSelector::_show_popup
calledPopupMenu::take_mouse_focus
, which calledViewport::pass_mouse_focus_to
, which did nothing because the_show_popup
is only called on left mouse button release and there is nomouse_focus
set when the mouse is released. Since that was the only usage these methods were removed.Viewport::pass_mouse_focus_to
is the only place thatgui.forced_mouse_focus
is set to true, so it is also removed.