-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shader doc comments to show up for instance
uniforms
#95652
base: master
Are you sure you want to change the base?
Fix shader doc comments to show up for instance
uniforms
#95652
Conversation
c5e927a
to
8748023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. But this only works when the shader is at material override, not when the shader is set to the mesh instance itself.
8748023
to
890b20c
Compare
Check again, I think I've fixed it. |
449bc15
to
cf897b2
Compare
@jsjtxietian Ok, I understood what you mean (A material property of a PrimitiveMesh), I think I've fixed it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works as expected.
86a2cee
to
ebe1c92
Compare
ebe1c92
to
cf4d914
Compare
instance uniform
does not show in inspector #95583