Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENet] Better handle disconnected peers in DTLS server #95067

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Aug 2, 2024

The ENetDTLSServer socket implementation should avoid reporting errors during send and receive operations, unless the socket is effectively no longer usable (and thus ENet should close it).

The ENetDTLSServer socket implementation should avoid reporting errors
during send and receive operations, unless the socket is effectively no
longer usable (and thus ENet should close it).
@Faless Faless requested a review from a team as a code owner August 2, 2024 14:07
@Faless Faless added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Aug 2, 2024
@akien-mga akien-mga added this to the 4.3 milestone Aug 2, 2024
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akien-mga akien-mga merged commit ed991f8 into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the enet/fix_dtls_disconnect branch August 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:multiplayer topic:network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants