Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obj's name set in wrong order when importing #94968

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix obj's name set in wrong order when importing #94968

merged 1 commit into from
Aug 12, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #94924

@jsjtxietian jsjtxietian requested a review from a team as a code owner July 31, 2024 04:51
clayjohn
clayjohn reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normal and tangent validation branch needs to be moved as well as it can change mesh_flags

@AThousandShips AThousandShips added bug topic:import regression cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:3d labels Jul 31, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Jul 31, 2024
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 12, 2024
@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 12, 2024
@akien-mga akien-mga merged commit 39fc116 into godotengine:master Aug 12, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the obj-import branch August 13, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release regression topic:import topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Obj import: messing up order of surface names, missing first, generating last.
4 participants
@jsjtxietian @akien-mga @clayjohn @AThousandShips