Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Fix wrong initial size passed to rendering driver #94398

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Windows: Fix wrong initial size passed to rendering driver #94398

merged 1 commit into from
Jul 17, 2024

Conversation

alvinhochun
Copy link
Contributor

DisplayServerWindows was passing the window size including the window frame. Pass the client size instead.

I am not sure if this has any visible effects, probably just a very minor thing.

@alvinhochun alvinhochun requested a review from a team as a code owner July 15, 2024 19:52
@YeldhamDev YeldhamDev added this to the 4.3 milestone Jul 15, 2024
bruvzg
bruvzg approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlikely will have any effect (GL ignores size completely, Vulkan and DX only use it when actually drawing).

@akien-mga akien-mga merged commit 38a537c into godotengine:master Jul 17, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@alvinhochun alvinhochun deleted the windows-rendering-driver-initial-size-fix branch July 17, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@alvinhochun @akien-mga @bruvzg @YeldhamDev