Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR: Couple of small fixes on the action map #94158

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

BastiaanOlij
Copy link
Contributor

@BastiaanOlij BastiaanOlij commented Jul 10, 2024

This PR makes 3 changes:

  1. CTRL-S and running your project now saves outstanding changes to the action map
  2. Opening the action map resource file no longer looses content if OpenXR is not enabled (important for projects that switch between XR and non-XR modes)
  3. Added a bit of documentation on haptic pulses (not really related but ran into it)

Fixes #90696

@BastiaanOlij BastiaanOlij added this to the 4.3 milestone Jul 10, 2024
@BastiaanOlij BastiaanOlij self-assigned this Jul 10, 2024
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner July 10, 2024 04:49
@BastiaanOlij BastiaanOlij requested a review from a team July 10, 2024 04:49
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bit of documentation on haptic pulses (not really related but ran into it)

If it's not related it should've been a separate PR but sure.

…ssed/project is run, no longer looses content if OpenXR is not enabled, and a small documentation fix.
@DanielSnd
Copy link
Contributor

This PR has fixed #90696 for me. I can no longer reproduce the problem using the steps I described on the issue after compiling the engine with this PR.

@akien-mga akien-mga merged commit b6434f2 into godotengine:master Jul 11, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_action_map branch July 11, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants