Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Call setter on simple setter chain without getter #94138

Merged

Conversation

vnen
Copy link
Member

@vnen vnen commented Jul 9, 2024

Fixes a bug where a member variable was being set directly before calling the setter.

Fix #85952

Fixes a bug where a member variable was being set directly before
calling the setter.
@vnen vnen added this to the 4.3 milestone Jul 9, 2024
@vnen vnen requested a review from a team as a code owner July 9, 2024 16:04
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@akien-mga akien-mga merged commit aefd91a into godotengine:master Jul 17, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@vnen vnen deleted the gdscript-simple-setter-chain-call-setter branch July 23, 2024 15:05
@bsil78
Copy link

bsil78 commented Jul 23, 2024

@vnen : I don't know where to put it, thus I write here since my question is related to this commit ; I am quite surprised that with this commit I have to define a getter in some cases when a setter is defined ? I got this new error : "Invalid call. Nonexistent function '@myclass_setter' in base 'Resource (Myclass)'" ; should not the default getter be used is such a case ?

@vnen
Copy link
Member Author

vnen commented Jul 23, 2024

@bsil78 the error means that it's calling a setter that doesn't exist, not a getter. Can you open an issue with a code snippet that reproduces this bug and tag me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setget inconsistent behaviour when modified by whole variable v.s. single property
4 participants