Fix VS project generation with SCons 4.8.0+ #94117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilbrunner
added
bug
platform:windows
topic:buildsystem
cherrypick:4.1
cherrypick:4.2
akien-mga
reviewed
Jul 9, 2024
akien-mga
removed
the
cherrypick:4.3
mhilbrunner
force-pushed
the
fix-94090-vsproj-scons-4.8
branch
from
0c52c1c to
f682406
Compare
|
@akien-mga Good catch, I just saw in the diff that they removed passing env in their own use, but we can indeed keep it for now. In any case, passing the parameters this way makes the code slightly less messy for now, I can adapt it if they change it further. :) |
akien-mga
approved these changes
Jul 9, 2024
|
Dear @mhilbrunner, i clone you reposetory by |
|
Thanks! |
|
@SavFox Thanks for testing, and thanks again for the great report :) |
akien-mga
added
cherrypick:3.x
|
Cherry-picked for 4.2.3, 3.x, 3.6.1, 3.5.4. Doesn't seem relevant for 4.1.x or 3.4.x or earlier. |
akien-mga
removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCons 4.8.0+ again (like in 4.6.0, see #85357) changes this piece of code, as reported in #94090 (thanks for the detailed report!).
I tested this with SCons 4.6.0 and 4.8.0 and both successfully generate VS projects for me. Would appreciate if @SavFox could verify this as well.
Fixes #94090.