-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: Fix IME blocking controls #94024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40px probably is an overkill, but it should fit font size (which 1px), it's probably better to have a few extra pixels (maybe 5px), also make sure it is tested in both Firefox and Chromium, they have quite different behaviour.
I guess width
can block controls as well, but I'm not sure what's the best solution, it should be big enough to not break the line (or suggestion window will be misaligned), maybe something like pointer-events: none;
will work to make it click through.
I've tested this in Windows with Firefox and Chrome, and 2 px seems to be enough. I can reproduce the earlier Windows Chrome issue and this didn't make it reappear. I hope 2 px is enough, 5 could make it clip noticeably with the tops of things below. Or maybe I'm just a hitarea perfectionist. |
Then again, if things are scaled maybe 2 px isn't enough... I'll make it 5 px just to be safe. |
967ade3
to
beab7ca
Compare
Setting pointer events to |
Thanks! |
Fixes #93996.