Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Fix IME blocking controls #94024

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

anniryynanen
Copy link
Contributor

Fixes #93996.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

40px probably is an overkill, but it should fit font size (which 1px), it's probably better to have a few extra pixels (maybe 5px), also make sure it is tested in both Firefox and Chromium, they have quite different behaviour.

I guess width can block controls as well, but I'm not sure what's the best solution, it should be big enough to not break the line (or suggestion window will be misaligned), maybe something like pointer-events: none; will work to make it click through.

@anniryynanen
Copy link
Contributor Author

40px probably is an overkill, but it should fit font size (which 1px), it's probably better to have a few extra pixels (maybe 5px), also make sure it is tested in both Firefox and Chromium, they have quite different behaviour.

I've tested this in Windows with Firefox and Chrome, and 2 px seems to be enough. I can reproduce the earlier Windows Chrome issue and this didn't make it reappear. I hope 2 px is enough, 5 could make it clip noticeably with the tops of things below. Or maybe I'm just a hitarea perfectionist.

@anniryynanen
Copy link
Contributor Author

Then again, if things are scaled maybe 2 px isn't enough... I'll make it 5 px just to be safe.

@anniryynanen anniryynanen force-pushed the ime-block branch 2 times, most recently from 967ade3 to beab7ca Compare July 7, 2024 09:34
@anniryynanen
Copy link
Contributor Author

Setting pointer events to none works too, that should be even safer.

@akien-mga akien-mga merged commit 39d9ff2 into godotengine:master Jul 7, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@anniryynanen anniryynanen deleted the ime-block branch July 8, 2024 04:14
@akien-mga akien-mga changed the title Fix IME blocking controls Web: Fix IME blocking controls Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web export ignores clicks under a focused LineEdit
4 participants