Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix USERDATA not copied when trails started #93595

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix USERDATA not copied when trails started #93595

merged 1 commit into from
Jun 26, 2024

Conversation

ueshita
Copy link
Contributor

@ueshita ueshita commented Jun 25, 2024

Fixes #93594

I have added code to the shader that I think is necessary.
Please point out if anything else is needed.

Before:
bug_trails_using_userdata

After:
bug_trails_using_userdata_fixed

@ueshita ueshita requested a review from a team as a code owner June 25, 2024 15:07
@Chaosus Chaosus added this to the 4.3 milestone Jun 25, 2024
clayjohn
clayjohn approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@akien-mga akien-mga merged commit 14d6be4 into godotengine:master Jun 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@ueshita ueshita deleted the fix_trails_using_userdata branch July 8, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:particles
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

USERDATA does not work when using GPU trails
4 participants
@ueshita @akien-mga @clayjohn @Chaosus