Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous non-working sample playing check #93428

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Remove superfluous non-working sample playing check #93428

merged 1 commit into from
Jun 21, 2024

Conversation

adamscott
Copy link
Member

This PR removes lines that were:

  1. not working properly;
  2. are not needed anyway.

Fixes #93420

@adamscott adamscott added this to the 4.3 milestone Jun 21, 2024
@adamscott adamscott requested a review from a team as a code owner June 21, 2024 11:19
@akien-mga akien-mga merged commit 8a6c1e8 into godotengine:master Jun 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@JekSun97 JekSun97 mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:audio
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

AudioStreamPlayer3D.is_playing() spams "Parameter p_playback is null"
2 participants
@adamscott @akien-mga