Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProgressDialog crash when importing TTF font #93161

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix ProgressDialog crash when importing TTF font #93161

merged 1 commit into from
Jun 14, 2024

Conversation

Hilderin
Copy link
Contributor

Fixes #93159

I added a check if something has changed before calling update_pending_script_classes and _update_pending_scene_groups to reproduce more closely the behavior before #93006

@akien-mga akien-mga requested review from KoBeWi and bruvzg June 14, 2024 13:07
@akien-mga akien-mga added this to the 4.3 milestone Jun 14, 2024
akien-mga
akien-mga approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes the issue, and the changes seem sensible.

@akien-mga akien-mga merged commit 8b271c8 into godotengine:master Jun 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@KoBeWi KoBeWi Awaiting requested review from KoBeWi

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
bug regression topic:import
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

ProgressDialog crash when importing TTF font at the same time as a big addon with glb files
2 participants
@Hilderin @akien-mga