Allow canceling actions in Path2D editor #93087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Jun 12, 2024
Comment on lines
-601
to
-607
| canvas_item_editor = nullptr; | ||
| mirror_handle_angle = true; | ||
| mirror_handle_length = true; | ||
| on_edge = false; | ||
|
|
||
| mode = MODE_EDIT; | ||
| action = ACTION_NONE; |
akien-mga
approved these changes
Jun 13, 2024
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right click to cancel current action:
godot.windows.editor.dev.x86_64_uOHsgU1PfO.mp4
I also reworked ACTION_MOVING_POINT to only create undo action once accepted (which is how it should've been implemented from the start 🤦♂️)
This fixes some bugs: