Fix theme updating of the inspector sections #93000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
fix_inspector_section_theming_update
branch
3 times, most recently
from
a3c6bab
to
035b411
Compare
Chaosus
force-pushed
the
fix_inspector_section_theming_update
branch
from
035b411
to
c5de67b
Compare
Chaosus
force-pushed
the
fix_inspector_section_theming_update
branch
2 times, most recently
from
6e8c864
to
388f93e
Compare
KoBeWi
reviewed
Jun 19, 2024
| @@ -1657,7 +1661,7 @@ void EditorInspectorSection::property_can_revert_changed(const String &p_path, b | |||
| } | |||
|
|
|||
| void EditorInspectorSection::_bind_methods() { | |||
| ClassDB::bind_method(D_METHOD("setup", "section", "label", "object", "bg_color", "foldable"), &EditorInspectorSection::setup); | |||
| ClassDB::bind_method(D_METHOD("setup", "section", "label", "object", "bg_color", "foldable", "indent_depth", "level"), &EditorInspectorSection::setup, DEFVAL(0), DEFVAL(1)); | |||
KoBeWi
reviewed
Jun 19, 2024
KoBeWi
reviewed
Jun 19, 2024
Chaosus
force-pushed
the
fix_inspector_section_theming_update
branch
from
388f93e
to
89dd710
Compare
KoBeWi
approved these changes
Jun 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #70356
I think it's more precise version than #70381 (not the whole inspector tree is updating, only sections to be redrawn) and have a chance to be merged.
Also fixes few incorrect places in code.
PS:
EditorInspectorSectionseems to be an internal class, so it's safe to merge without breaking change for the users.