Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native file dialogs being shown on set_visible(false) #92943

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix native file dialogs being shown on set_visible(false) #92943

merged 1 commit into from
Jun 10, 2024

Conversation

anniryynanen
Copy link
Contributor

@anniryynanen anniryynanen commented Jun 9, 2024 •
edited
Loading

I was pretty confused when get_tree().root.propagate_notification(Node.NOTIFICATION_WM_CLOSE_REQUEST) popped up all my file dialogs.

Here's a MRP: native-file-dialog-wm-close.zip

Fixes #92946.

@anniryynanen anniryynanen requested a review from a team as a code owner June 9, 2024 14:59
@AThousandShips
Copy link
Member

Please open a bug report to track this

@AThousandShips AThousandShips added this to the 4.3 milestone Jun 9, 2024
@akien-mga akien-mga merged commit 7128667 into godotengine:master Jun 10, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jun 10, 2024 •
edited
Loading

Thanks!

@anniryynanen anniryynanen deleted the less-file-dialogs branch June 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Calling set_visible(false) on native file dialogs shows them instead
4 participants
@anniryynanen @AThousandShips @akien-mga @bruvzg