Audio stream polyphonic #92852
Closed
Audio stream polyphonic #92852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6fa77e0)
(cherry picked from commit dec6351)
Synced with mdqinc/SDL_GameControllerDB@232c738 (cherry picked from commit 10445d8)
(cherry picked from commit 72b80b3)
ReShade can still be used on projects run from the editor as well as exported projects. This avoids several issues: - ReShade doesn't play well with low-processor mode, making it hard to use unless the Update Continuously editor setting is enabled. - The ReShade overlay appears on every popup opened, which made popups unusable. - If you use a ReShade configuration that heavily affects the image, it won't affect the editor UI which may become unreadable as a result. This doesn't affect the editor being run via OpenGL or Direct3D 12 as ReShade is injected in a different manner when using those graphics APIs. (cherry picked from commit 67b8d71)
(cherry picked from commit 48ed047)
(cherry picked from commit ab14dec)
(cherry picked from commit 41268d7)
(cherry picked from commit 179b078)
(cherry picked from commit e248504)
(cherry picked from commit c07991e)
…o rg (cherry picked from commit 4f41b94)
(cherry picked from commit 112f489)
(cherry picked from commit 547f03b)
Global position doesn't get adjusted within `InputEventMouse::xformed_by()`. (cherry picked from commit 8de3991)
(cherry picked from commit 75ba837)
Handle the case correctly, that a child of a replaced node has as owner an ancestor of the replaced node. (cherry picked from commit c58607c)
(cherry picked from commit 713ea06)
(cherry picked from commit f267b2a)
(cherry picked from commit 1430f0b)
…are good enough when using compression (cherry picked from commit 781cd27)
(cherry picked from commit 14c776f)
(cherry picked from commit 734166f)
(cherry picked from commit ead36fd)
(cherry picked from commit ce48893)
(cherry picked from commit 54747fa)
(cherry picked from commit b65635a)
…port. (cherry picked from commit 620e194)
|
@ditiem-games Is there an associated bug report? If not, I suggest opening one. Also, your PR was closed as you accidentally rebased your branch over |
Ok, I retry. Here is the pull request. The bug fixed is in the comment (as it was before): Hope it helps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are for 4.2.2-stable.
Tested with my own game and works as expected.
The bug in the code happens because the index of the streams is recorded in the returned ID:
return (ID(i) << INDEX_SHIFT) | ID(streams[i].id);Whenever an stream is deleted, or the returned ID is stored in gdscript and some other stream replaces the old (non active) one, things will go wrong.