Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some incorrect uses of String over StringName #92723

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix some incorrect uses of String over StringName #92723

merged 1 commit into from
Jun 3, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jun 3, 2024 •
edited
Loading

These were accepting SNAME assignments (alternatively the SNAMEs should be removed, but I think this is the way it was intended)

@AThousandShips
Fix some incorrect uses of String over StringName
0f72b15 
These were accepting `SNAME` assignments
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 3, 2024
@AThousandShips AThousandShips requested review from a team as code owners June 3, 2024 11:46
@akien-mga akien-mga merged commit 5f1184e into godotengine:master Jun 3, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the incorrect_sname branch June 3, 2024 14:01
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @akien-mga