[Button] Adds theme option to align button text and icon to either largest or current stylebox. #92701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Jun 2, 2024
|
Tested, hover-pressed buttons look fine, including icons, but this doesn't seem to fix #92466: 
|
Updated, should fix it as well. |
Works 🙏 |
Closed
akien-mga
reviewed
Jun 10, 2024
…rgest or current stylebox.
KoBeWi
reviewed
Jun 10, 2024
| @@ -828,6 +850,8 @@ void Button::_bind_methods() { | |||
|
|
|||
| BIND_THEME_ITEM(Theme::DATA_TYPE_CONSTANT, Button, h_separation); | |||
| BIND_THEME_ITEM(Theme::DATA_TYPE_CONSTANT, Button, icon_max_width); | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
Although the types aren't really sorted/grouped properly anway.
KoBeWi
approved these changes
Jun 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #92625
Adds new theme option (disabled for default theme and enabled for the editor theme) to control whether button elements are aligned to largest or current stylebox.
Fixes button issues cause by #92009 without reintroducing #92009 (comment)
Fixes #92602
Fixes #92466