Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing space around the ratio lock button #92482

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add missing space around the ratio lock button #92482

merged 1 commit into from
Jun 3, 2024

Conversation

passivestar
Copy link
Contributor

Before:

1

After:

2

@AThousandShips AThousandShips requested a review from a team May 29, 2024 08:34
@AThousandShips AThousandShips added this to the 4.x milestone May 29, 2024
KoBeWi
KoBeWi approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about using a hard-coded value for that, but surprisingly 24 * ESCALE is already used a few times in the codebase. Proper value would be class_icon_size + 8 * EDSCALE.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 2, 2024
@passivestar
Copy link
Contributor Author

Proper value would be class_icon_size + 8 * EDSCALE

Didn't realize that icon size is themable, fixed now

@akien-mga akien-mga merged commit f882f12 into godotengine:master Jun 3, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the ratio-space branch June 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@passivestar @akien-mga @KoBeWi @AThousandShips