Properly set window class in Wayland

[poiati]

When using the Wayland display server, the window is initialized before the class is set. This means that every window has the same initial class as the Editor, making it impossible to create rules in compositors to, for instance, set the game window to a different monitor (this is important, as in Wayland, it's not possible to choose a monitor through the application).

Example: $ hyprctl clients

Master:

{
    "address": "0x5aedf5158070",
    "mapped": true,
    "hidden": false,
    "at": [1933, 748],
    "size": [1259, 679],
    "workspace": {
        "id": 1,
        "name": "1"
    },
    "floating": false,
    "monitor": 1,
    "class": "test",
    "title": "test (DEBUG)",
    "initialClass": "org.godotengine.Editor",
    "initialTitle": "Godot",
    "pid": 35734,
    "xwayland": false,
    "pinned": false,
    "fullscreen": false,
    "fullscreenMode": 0,
    "fakeFullscreen": false,
    "grouped": [],
    "swallowing": "0x0",
    "focusHistoryID": 1
}

This build:

{
    "address": "0x5aedf5178610",
    "mapped": true,
    "hidden": false,
    "at": [1933, 53],
    "size": [1259, 679],
    "workspace": {
        "id": 1,
        "name": "1"
    },
    "floating": false,
    "monitor": 1,
    "class": "test",
    "title": "test (DEBUG)",
    "initialClass": "test",
    "initialTitle": "Godot",
    "pid": 36466,
    "xwayland": false,
    "pinned": false,
    "fullscreen": false,
    "fullscreenMode": 0,
    "fakeFullscreen": false,
    "grouped": [],
    "swallowing": "0x0",
    "focusHistoryID": 1
}

[bruvzg]

Note: Windows DisplayServer do the similar stuff with a local check (was done for the same reason, AppID should be set before showing window), with this PR merged, it can be changed to use context as well.

godot/platform/windows/display_server_windows.cpp

Line 5295 in 8e2141e

appname = "Godot.GodotEditor." + String(VERSION_BRANCH);

godot/platform/windows/display_server_windows.cpp

Line 5766 in 8e2141e

appname = "Godot.GodotEditor." + String(VERSION_BRANCH);

[Riteo]

Mh that's interesting. I had no idea rules had an "initial" set of properties.

I'm not against the change, but I'm curious what stops people from using the non-initial window properties?

[Riteo]

Anyways, the code looks nice and simple! Wayland/X11-side things look A-OK, but don't forget to also take into account bruvzg's review :)

[poiati]

Anyways, the code looks nice and simple! Wayland/X11-side things look A-OK, but don't forget to also take into account bruvzg's review :)

Hi Riteo,

In Hyprland, we have two types of window rules: static and dynamic. Static rules only take the initial properties, as they are executed when the window is instantiated. This is where I would select in which monitor I want to display the window, or whether I want it to be fullscreen or floating. Unfortunately, I cannot do that through dynamic rules, which read the current title and class. You can read more about it here: https://wiki.hyprland.org/Configuring/Window-Rules/.

PS: You did amazing work with the Wayland display server. Thank you!

[Riteo]

@poiati

Unfortunately, I cannot do that through dynamic rules, which read the current title and class.

Makes perfect sense, thanks for clarifying!

PS: You did amazing work with the Wayland display server. Thank you!

You're welcome :D

There's still a lot to do and your testing and contribution is very appreciated!

[akien-mga]

Thanks!