Add colored header output #92209
Open
Add colored header output #92209
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header messages are now displayed in gray, with the rendering method being colorized in the message. ANSI escape codes are now stripped in the editor Output panel as well, which allows scripts to use custom ANSI escape codes outside of `print_rich()` while not affecting the Output panel's readability. This change was required for the newly printed ANSI escape codes to avoid affecting the editor Output panel. Additionally, the dim/faint display mode is now used instead of a "bright black" color for better compatibility across terminals (some themes could be displaying black text on a black background otherwise, or white text on a white background).
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip ANSI escape codes from file logging #90900.
Header messages are now displayed in gray, with the rendering method being colorized in the message.
ANSI escape codes are now stripped in the editor Output panel as well, which allows scripts to use custom ANSI escape codes outside of
print_rich()while not affecting the Output panel's readability. This change was required for the newly printed ANSI escape codes to avoid affecting the editor Output panel. Message collapsing still works as expected:Additionally, the dim/faint display mode is now used instead of a "bright black" color for better compatibility across terminals (some themes could be displaying black text on a black background otherwise, or white text on a white background).
The Forward Mobile rendering method is now called Mobile in the startup message, for consistency with the editor display.
cc @Repiteo, as the dim/faint display mode (
[2m) could be helpful for the SCons build time line where we used a 256-color gray previously to avoid the terminal theming issue.Preview
The exact colors displayed will vary depending on your terminal emulator and its color scheme.