[SCons] Add options to override AR, AR and RC flags #91972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 15, 2024
SConstruct
Outdated
Comment on lines
282
to
284
| opts.Add("CXX", "C++ compiler binary") | ||
| opts.Add("CC", "C compiler binary") | ||
| opts.Add("LINK", "Linker binary") |
There was a problem hiding this comment.
To clarify, exposing the *flags as done in this PR should be fine to merge already, as this will work fine.
Making it possible to actually override the binary for each step reliably will require more work and an approach similar to #91743, so we can leave that to discuss there.
There was a problem hiding this comment.
Should we also add options for AS, AR, RANLIB, RC, and maybe S_compiler?
Why not? I have not tested #91743, but it seems fine to me (at least the idea).
akien-mga
reviewed
May 15, 2024
akien-mga
changed the title
akien-mga
approved these changes
May 15, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra options to override flags for the assembler, archive tool and resource compiler, similar to
c**flagsandlinkflags.