[Editor] Prevent some shortcut errors when generating docs

[AThousandShips]

Makes the check for EditorSettings singleton in the shortcut override methods silent to avoid errors on documentation generation

To see the change compare the CI run of this and master for example, this will turn up at the top of both the class reference update and the C# glue:

ERROR: EditorSettings not instantiated yet.
   at: ED_SHORTCUT_OVERRIDE_ARRAY (editor/editor_settings.cpp:1658)
ERROR: EditorSettings not instantiated yet.
   at: ED_SHORTCUT_OVERRIDE_ARRAY (editor/editor_settings.cpp:1658)

• Fixes: "ERROR: EditorSettings not instantiated yet." when running --doctool or --generate-mono-glue #91510

[akien-mga]

How about removing the error check in ED_SHORTCUT_OVERRIDE* instead, and just make it a silent return?

[AThousandShips]

Could do that, but it is an action that expects things to work so might be safer to have it error correctly when it's expected to work correctly, but can make an alternative solution like that

The non-override versions do exit silently so could equalize that

Will make a second commit with that solution instead and we'll decide which to go with

Edit: Alternative fix, while also removing all those checks existing already, will see what CI says but it seems to work just as well, only drawback is that we won't get errors when we might want to otherwise, but less hacky

[akien-mga]

Yeah I think we can go with this alternative solution.

[akien-mga]

Thanks!

[AThousandShips]

Thank you!