Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep docks menu open when opening dock #91484

Merged
merged 1 commit into from
May 11, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented May 2, 2024

If opening a dock, keep the menu open so more docks can be opened.
When focusing a dock, it closes.

godot dockmenu stay open

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it wouldn't be better to make focus_dock() return a bool instead of partially duplicating it, but it's fine this way too.

@kitbdev
Copy link
Contributor Author

kitbdev commented May 10, 2024

Rebased and updated.
It's not really duplicating part of focus_dock, just changing behavior based on current open/closed state, I'd say.
Also if we do want to change to open/close and checkboxes like mentioned in RC, then manually closing the parent menu like this won't be necessary.

@akien-mga akien-mga merged commit 65f81e4 into godotengine:master May 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the open-stay-open branch May 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants