Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the gradle build logic used to generate the Godot Android binaries #91271

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Clean up the gradle build logic used to generate the Godot Android binaries #91271

merged 2 commits into from
Aug 16, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 28, 2024

No description provided.

@m4gr3d m4gr3d added this to the 4.4 milestone Apr 28, 2024
@m4gr3d m4gr3d requested a review from raulsntos April 28, 2024 05:30
@m4gr3d m4gr3d requested a review from a team as a code owner April 28, 2024 05:30
@m4gr3d m4gr3d mentioned this pull request Apr 28, 2024
Merged
raulsntos
raulsntos approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak for the Android team, but this looks reasonable to me and helps me implement #88803. Thank you!

@m4gr3d m4gr3d force-pushed the clean_gradle_build_setup branch from 86520a3 to f63fbc8 Compare May 3, 2024 06:51
raulsntos
raulsntos reviewed May 13, 2024
View reviewed changes
@m4gr3d m4gr3d force-pushed the clean_gradle_build_setup branch from f63fbc8 to ffb1a9b Compare May 13, 2024 18:18
@m4gr3d m4gr3d force-pushed the clean_gradle_build_setup branch from ffb1a9b to d38c5b6 Compare May 31, 2024 13:21
@akien-mga akien-mga merged commit 690c566 into godotengine:master Aug 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the clean_gradle_build_setup branch August 16, 2024 16:11
@jss2a98aj jss2a98aj mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @akien-mga @raulsntos