Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further speed up closing multiple scripts #91081

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 23, 2024

Follow-up to #78604
Script closing is still annoyingly slow. This PR skips everything related to script history. Now closing many scripts is fast even in dev build.

@KoBeWi KoBeWi added this to the 4.x milestone Apr 23, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner April 23, 2024 21:34
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 24, 2024
@akien-mga akien-mga merged commit a4fbe4c into godotengine:master Apr 24, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the closing_faster_than_light branch April 24, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants