Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong Tree column title position #91044

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix wrong Tree column title position #91044

merged 1 commit into from
Apr 23, 2024

Conversation

timothyqiu
Copy link
Member

Before

before

After

after
  • Removes extra spacing on the left side of the centered column title
  • When calculating minimum size of a column, the padding of column title should come from title_button (background of title buttons) instead of panel_style (background of the tree)

@timothyqiu timothyqiu added bug topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 23, 2024
@timothyqiu timothyqiu added this to the 4.3 milestone Apr 23, 2024
@timothyqiu timothyqiu marked this pull request as ready for review April 23, 2024 08:08
@timothyqiu timothyqiu requested a review from a team as a code owner April 23, 2024 08:08
@akien-mga akien-mga merged commit a3b9344 into godotengine:master Apr 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the column-title branch April 23, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @akien-mga @KoBeWi