Fix TabContainer using wrong content rect after tab title update #91038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
topic:gui
cherrypick:4.2
YeldhamDev
approved these changes
Apr 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #90942.
This PR fixes a bug that only happens when you update tab title after updating tab icon. Updating tab icon before updating tab title is fine.
3.xdoes not have this bug.Tab title can affect minimum size even when clipping tabs (e.g. changing from using empty title to some visible text).
The magenta rect is the tab content.
Test project: tab-container.zip