LSP: Have GDScriptWorkspace::list_script_files respect .gdignore.
#90949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poke. Is there anything more I need to do here? |
|
I'm not sure, it looks right to me but the GDSctipt team would have to give their opinion, probably not as active now on the weekend |
akien-mga
changed the title
GDScriptWorkspace::list_script_files respect .gdignore.
|
Thanks! |
akien-mga
added
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Godot would list and try to load all .gd scripts even if they're in a directory with a .gdignore file.
This was causing me issues because I have some symlinks setup in my repo that meant Godot was accidentally seeing two copies of a bunch of files. This lead to a bunch of errors when every file was loaded twice.
I also changed the formatting slightly to return early if there's an error opening a directory.