Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Clarify behavior of FileAccess.get_line #90766

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Apr 16, 2024

Specifies that the line excludes any newline or carriage return characters.

See here for the implementation:

if (c == '\n' || c == '\0') {
line.push_back(0);
return String::utf8(line.get_data());
} else if (c != '\r') {
line.push_back(c);
}

@AThousandShips AThousandShips added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 16, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 16, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner April 16, 2024 17:19
Specifies that the line excludes any newline or carriage return
characters.
@akien-mga akien-mga merged commit ec2e394 into godotengine:master Apr 17, 2024
16 checks passed
@AThousandShips AThousandShips deleted the file_doc branch April 17, 2024 09:02
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get-line function from FileAccess not specifying if '\n' and '\r' are included or not [4.2.1]
3 participants