Fix leakage of JNI object references #90710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
bug
platform:android
topic:porting
needs testing
cherrypick:4.2
|
I've tested it out on an S6 Edge running Android 7, its a perfect fix. |
akien-mga
approved these changes
Apr 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87548
The issue occurred because we were continuously allocating local references to
jstringobjects inGodotJavaWrapper::has_feature(...)and not deleting them after using them.In addition to deleting local references in that method, I took a pass at the rest of the codebase and did the same where needed.
Additional testing would be appreciated to ensure no regressions where introduced in the cleanup.