Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logic to load export preset's options overrides #90606

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Fix the logic to load export preset's options overrides #90606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions editor/export/editor_export.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ void EditorExport::update_export_presets() {
if (platform_options.has(preset->get_platform()->get_name())) {
export_presets_updated = true;

bool update_value_overrides = false;
List<EditorExportPlatform::ExportOption> options = platform_options[preset->get_platform()->get_name()];

// Clear the preset properties prior to reloading, keep the values to preserve options from plugins that may be currently disabled.
Expand All @@ -377,6 +378,13 @@ void EditorExport::update_export_presets() {
preset->values[option_name] = E.default_value;
}
preset->update_visibility[option_name] = E.update_visibility;
if (E.update_visibility) {
update_value_overrides = true;
}
}

if (update_value_overrides) {
preset->update_value_overrides();
}
}
}
Expand Down
Loading