Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node3D.set_global_rotation() resetting node scale. #90584

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix Node3D.set_global_rotation() resetting node scale. #90584

merged 1 commit into from
Apr 18, 2024

Commits on Apr 16, 2024

  1. Fixes the issue where setting global rotation would reset scale. 

    This was caused because the basis for the target global transform was entirely recreated. This process did not account for the scale of the basis of the current global transform.
This PR amends this by scaling the recreated basis for the global transform by the current global scale of the Node3D.
Note that this scaling has to be done from the current global scale and not from the local scale of the Node3D, otherwise issues would arise if parents of this Node3D would be scaled.
    @BMagnu
    BMagnu committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    dd97ff4 View commit details
    Browse the repository at this point in the history