Rearrange "Open In" menu items of FileSystem dock

[timothyqiu]

Closes godotengine/godot-proposals#9483

	Before	After
Directory
File

This PR:

• Makes "Show in File Manager" the last one because it's the most frequently used one.
• Makes the terminal one first because it operates on the containing folder, different from the other two.

The diff looks messy. It's actually just swapping those two groups of codes.

[kitbdev]

Should also be done in _file_list_empty_clicked and _tree_empty_click.

[akien-mga]

Makes "Show in File Manager" the last one because it's the most frequently used one.

Is that a well established UX pattern? I would expect the most frequently used one to be the first entry in a list, not the last.

[KoBeWi]

It can be either first or last element, as they are most accessible (you don't have to search in the middle of the list).
And arguably, separators can be treated like "sub-lists", so the position was fine before.

I accidentally opened the terminal at least twice so far, while trying to open something in external program. If the least used option is supposed to be in the middle, for me that would be the terminal one.

[timothyqiu]

Is that a well established UX pattern? I would expect the most frequently used one to be the first entry in a list, not the last.

Yes. The last item can be easily located too. It's the same reason Close Window button being the last entry on the title bar (it's the first entry for a macOS window as these buttons are left aligned there).

Although being the first entry after the separator, "Show in File Manager" is still in the middle of the context menu.

[akien-mga]

Thanks!