Core: Use <type_traits> where applicable
#90540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
I support this.
In fact, I have been working on #91104 and this has made me want to finish it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of utilizing alternative implementations for metaprogramming types, this PR instead makes
type_info.hinclude<type_traits>instead. The only other file that was usingtype_info.hfunctions was already including<type_traits>, so that takes care of an existing reduncancy.GetTypeInfofor Objects was able to be simplified to a single template, as theis_base_of_vconditional handles const conversion automatically.Granted, I really like the idea of having a custom, trimmed-down version of
<type_traits>for our own use, similar to our trimmed down String vsstd::string. Though, that's better suited as a dedicated file imo. I'll probably look into a version of that sometime soon; but, for now, uniformly utilizing<type_traits>is the way to go.