Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder colors not saving after project.godot is modified externally #90525

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 11, 2024

  1. Open a project
  2. Open project.godot in text editor, modify and save it
  3. When external modification prompt appears in Godot editor, reload the file
  4. Assign folder colors
  5. The colors won't be saved until you restart the editor, meaning all your new colors are lost

This PR updates Dictionary reference when project settings are changed, so it can be saved properly.

@KoBeWi KoBeWi requested a review from a team as a code owner April 11, 2024 10:23
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 11, 2024
@akien-mga

This comment was marked as resolved.

@akien-mga akien-mga merged commit 665a98b into godotengine:master Apr 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the color_limbo branch April 13, 2024 10:54
@akien-mga akien-mga changed the title Fix folder colors not saving after project.godot is modifed externally Fix folder colors not saving after project.godot is modified externally Aug 14, 2024
@akien-mga akien-mga changed the title Fix folder colors not saving after project.godot is modified externally Fix folder colors not saving after project.godot is modified externally Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants