Bump GitHub workflows to SCons 4.7 #90304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine. Which version to use on CI is a tradeoff, as it also makes sense to use an older version to ensure that it still works, since the older versions we support are likely less tested by contributors than the most recent ones. But this was already on a fairly recent version so I think it's fine to move to latest. If/how to test older versions is an open question, but we have limited CI resources so we can't extend the build matrix too much. We could possibly have some specific builds changed to use older SCons versions, but we need to make sure we're not then reducing the testing coverage too significantly for the latest one. |
akien-mga
approved these changes
Apr 8, 2024
akien-mga
added
the
cherrypick:3.x
akien-mga
changed the title
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All -
There are some changes in SCons 4.7 (which I was involved with over the past year) around job scheduling and caching. Godot users building from source may well encounter 4.7 (it is, for instance, recently the default SCons in homebrew), so it seems like a worthwhile idea to validate that it works, at least within the context of Godot's GH workflows.