Fix scroll to description #90035
Merged
Fix scroll to description #90035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
SUPER_CALL_DEFERRED
branch
from
b43f527
to
5a8066b
Compare
ajreckof
approved these changes
Apr 13, 2024
akien-mga
approved these changes
Apr 13, 2024
|
Thanks! |
|
Thanks for fixing a regression from my pr... I've been quite busy lately so it could've taken some time for me to do it 😅 |
AThousandShips
added
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88281
I verified that
scroll_to_paragrah()is called with the same argument, but apparently it's too early, because it scrolls to completely wrong position. I tried settingscroll_toregardless ofis_ready(), but it doesn't help.I call the thing I used "super_call_deferred()" in my project and it sometimes helps me to fix bugs, but I didn't expect that it would help in the engine too :/ If anyone knows a better solution feel free to suggest it, but the issue has to be fixed quick, because it's annoying.
EDIT:
I did something less hacky.