Add override mark to ResourceFormat class
#89863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Mar 25, 2024
akien-mga
approved these changes
Mar 25, 2024
I wouldn't, I think the blame ignore should only include cosmetic changes, but this one actually has implications on how code is compiled. If a downstream user has their custom code fail compiling because of this change (missing |
|
Isn't that compile issue only if you mix it in the same class? |
|
Possibly. Still, it's not a cosmetic change so I wouldn't hide it from blame :) |
akien-mga
changed the title
override mark to ResourceFormat class
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
0acfb38
akien-mga
added a commit
that referenced
this pull request
Mar 25, 2024
Add `override` mark to ResourceFormat class
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
overrideto class derived fromResourceFormatSaverandResourceFormatLoader. It helps me understand codes.