Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AnimationPlayer pin behavior #89732

Merged
1 commit merged into from
Mar 24, 2024
Merged

Fix AnimationPlayer pin behavior #89732

1 commit merged into from
Mar 24, 2024

Conversation

azuloo
Copy link
Contributor

@azuloo azuloo commented Mar 21, 2024 •
edited by akien-mga
Loading

Fixes issues described by #85285 . Also fixes situation described by @KoBeWi where if you remove the pinned AnimationPlayer from the scene - the AnimationPlayerEditor becomes stuck.

Bugsquad edit:

@TokageItLab TokageItLab requested review from a team March 21, 2024 10:16
@akien-mga akien-mga added this to the 4.3 milestone Mar 23, 2024
@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
@akien-mga
Merge pull request #89732 from azuloo/animation-player-pin-fix
391eaf2 
Fix AnimationPlayer pin behavior
@akien-mga
Copy link
Member

Thanks!

@azuloo azuloo deleted the animation-player-pin-fix branch March 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Animation editor's Pin button wrong behavior.
4 participants
@azuloo @akien-mga @KoBeWi @TokageItLab