[X11] Add more details to large icon size warning #89716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
AThousandShips
changed the title
|
Please make your commit message more clear, the title of the PR would be good |
AThousandShips
changed the title
AThousandShips
changed the title
AThousandShips
changed the title
Calinou
reviewed
Mar 21, 2024
|
should I currently do any changes? |
|
@AThousandShips should I do any corrections? |
|
You need to fix the commit message and please squash your commits into one, see here |
…help faster find it
|
@AThousandShips updated please check |
|
@AThousandShips is it possible to merge and close this PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searched my icons till not add this size info, I think it will simplify life for a lot of developers/designers.