Add navigation baking crash prevention mechanism #89692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism (enabled by default) that interrupts navigation mesh baking if it's very likely to fail or crash the engine.
This mechanism can be disabled in the project settings.
Rationale:
The current problem is as follows - if the navmesh baking is likely to fail or crash the engine, the warning is being printed. In case of engine crash, this is of very little help as the developer probably won't see it anyway. It leads to numerous issues like #87267 being reported.
See https://chat.godotengine.org/channel/navigation?msg=ZkocD7ZRbaDgTRCoB