Move the line of infinity loop checking in AnimationStateMachine #89575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
TokageItLab
force-pushed
the
move-loop-check-state
branch
from
bcff295
to
b8d555c
Compare
TokageItLab
added
cherrypick:4.2
|
crosses fingers This warning ate up hours of my time as I tried to figure out what I was doing wrong. I don't know how to boost visibility of this pull request, but I very much want it to be merged. |
|
I can confirm that this PR fixes the problem for me! |
fire
approved these changes
Mar 30, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
|
Cherry-picked for 4.1.4. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch_mode = at_end#82935 (Maybe, but i'm not sure since there is no MRP)The checking for transition by
At Endis performed in_can_transition_to_next(). It is a normal termination that does not require a warning, so it should be performed prior to the infinite loop checking.