Fix missing gutter icon for inner class method overrides #89545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedMser
reviewed
Mar 15, 2024
brno32
force-pushed
the
override-gutter-icon-inner-class-method
branch
from
d7f6717
to
56d7ec3
Compare
RedMser
approved these changes
Mar 16, 2024
|
Haven't tested but code changes look good. |
Paulb23
reviewed
Mar 25, 2024
brno32
force-pushed
the
override-gutter-icon-inner-class-method
branch
from
56d7ec3
to
1d93a1f
Compare
|
Thanks! |
|
No problem! I didn't get to push up a change to reflect @Paulb23's feedback, so if that's still wanted, I opened a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69023
Also handles inner, inner classes! And inner, inner, inner classes... and so on.
